Fix some build-time bugs for release v7 #1083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_thompson as dependency since it is a sub-dependency
grantfirl
requested review from
Qingfu-Liu,
dustinswales,
WeiguoWang-NOAA and
ericaligo-NOAA
as code owners
dustinswales
approved these changes
Aug 29, 2024
There was a problem hiding this comment.
@grantfirl Thanks for making these changes so quickly!
(At first I was confused why this needed to be added, sub-dependencies...)
climbfuji
approved these changes
Aug 29, 2024
hertneky
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@hertneky discovered some build problems.
First, when compiling only suites that don't need Thompson (but still have dependencies on module_mp_thompson.F90 through radiation interstitials), the module_mp_radar.F90 file was missing as a sub-dependency listed in metadata. This has been fixed.
Second, the
-DCCPP_SUITES=ALLoption in cmake failed to build due to compilation issues in YSU PBL and FA MP. These problems have been fixed.